Add warning for type checking upgrades at compile time for bad metadata

digital-asset / daml

The Daml smart contract language

https://www.digitalasset.com/developers

797 stars 199 forks source link

Add warning for type checking upgrades at compile time for bad metadata #19492

Open basvangijzel-DA opened 2 months ago

basvangijzel-DA commented 2 months ago

Given that we are using the upgrades field in the daml.yaml. Consider giving a warning, that can be disabled for the following cases:

[ ] package name is different from the package in the upgrades field
[ ] warning if the version number is the same or older (possibly consider generalising the upgrades field to upgrades and downgrades before implementing this).

daravep commented 3 weeks ago

@dylant-da Why wouldn't we display this as an error? If I define an upgrade dependency, shouldn't the compiler insist that the package names are consistent? If they are not consistent, the upgrade dependency wouldn't have any effect, so shouldn't be defined at all. No?

dylant-da commented 2 weeks ago

The current behaviour is a leftover from the prior approach when we didn't check dependencies and so package names ultimately didn't matter until upload. I agree that it should be turned into an error.