digital-asset / daml

The Daml smart contract language
https://www.digitalasset.com/developers
797 stars 199 forks source link

Daml-script communication needs to be more robust #19804

Open samuel-williams-da opened 3 weeks ago

samuel-williams-da commented 3 weeks ago

From Curtis, a description of the problem:

Netty retry findings

It appears that daml-script's underlying Netty Channel when using GRPC doesn't use any retry logic. The channel builder LedgerClientChannelConfiguration.builderFor sets up TLS and message sizes, but doesn't setup:

.enableRetry()
.maxRetryAttempts(10)

for example. There is also information here on retry directly in GRPC. I've seen a sentiment online that maxRetryAttempts isn't enough.

dylant-da commented 3 weeks ago

Will be discussed in grilling, will move then