digital-asset / daml

The Daml smart contract language
https://www.digitalasset.com/developers
797 stars 199 forks source link

Performance for upgrades checking #19859

Open dylant-da opened 2 weeks ago

dylant-da commented 2 weeks ago

When checking modules individually for upgrade validity we re-run the following for each module:

It would be ideal if we could save a lot of effort on each module where possible. This will require a bit of rearchitecting of the upgrade checking logic.

paulbrauner-da commented 2 weeks ago

Also here, the filter could produce a lazy map that would only test as we iterate over the keys, since we return an error for the first one only.