search

digital-asset / ex-bond-trading

A simple bond trading application
Apache License 2.0
16 stars 13 forks source link

Devops! #2

Closed jordan-da closed 5 years ago

jordan-da commented 5 years ago
pajb-da commented 5 years ago

So it looks like the CI makefile is separate from the local Makefile, and someone pulling down the repo can still use that to build and run - correct. The cicd.mk file is just to drive the CI build and test right?

jordan-da commented 5 years ago

That is correct, but it isn't necessarily for cicd, I just called it that due to lack of imagination. It can (and will be) used locally by those that don't have the entire suite of tools needed installed on their local workstation. I don't expect developers to maybe use it as it is, they will want to use the tools local to them, tools already hooked into their IDEs.

So my question is, should the cicd.mk makefile be the the main Makefile? Should I add a flag to turn on true local development (ie not inside docker containers) and merge the differential features over? What would be least disruptive to you?

pajb-da commented 5 years ago

I think it would be good to have just one Makefile, useable for both local and CI builds/tests etc. - as you say, local devs might want to use local tools hooked up to the IDE, so it should allow both local and docker based work. How to achieve this? I'm fine with merging the two, but just so I can learn what you've done, perhaps I can do it - with your guidance? Let's discuss - tomorrow?

jordan-da commented 5 years ago

need to recreate this PR to get circleci to kick in

jordan-da commented 5 years ago

@pajb-da lets hold off on merging the makefiles for now.. we should do it in separate PR i think

jordan-da commented 5 years ago

this addresses https://github.com/digital-asset/ex-bond-trading/issues/1