digital-asset / ex-java-bindings

Three examples demonstrating three different approaches to using the Java ledger API bindings
Apache License 2.0
12 stars 9 forks source link

Minimal changes to work in Daml 2.0 #14

Closed arobert-da closed 2 years ago

arobert-da commented 2 years ago

I needed an example of 2.0 ledger API access for another project so I modified this example, starting from #13.

EDIT: Marking this PR as Draft because while the gRPC version runs similarly to on master, the output for the Reactive version is jumbled up at first and then deadlocks. I’ve included the ouput and the suspicious threads from the thread dump in the attached file.

java-bindings-problems.txt

digitalasset-cla commented 2 years ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: arobert-da
:x: realvictorprm
You have signed the CLA already but the status is still pending? Let us recheck it.

realvictorprm commented 2 years ago

so using a locally adjusted snapshot version where I reverted a commit I was able to get rid of the deadlocks, however it still didn't work correctly. After some investigation I found out that not all transactions are streamed correctly and I suspect now that there is a bug in the TransactionClientImpl.

realvictorprm commented 2 years ago

so using a locally adjusted snapshot version where I reverted a commit I was able to get rid of the deadlocks, however it still didn't work correctly. After some investigation I found out that not all transactions are streamed correctly and I suspect now that there is a bug in the TransactionClientImpl.

arobert-da commented 2 years ago

Incorporated into https://github.com/digital-asset/ex-java-bindings/pull/15 (merged)