search

digital-cognition-co-in / DigitalCognition

DigitalCognition - Main repo - Core Product
2 stars 2 forks source link

change_to_upper_task #1

Closed avirupchattaraj closed 4 years ago

RohitDhankar commented 4 years ago

Udit , Avirup , we all need to discuss and decide - which existing Python Module / .py , file within the project should the code written by Avirup go into . My suggestion is - /home/dhankar/_dc_main/DigitalCognition/dc_dash/eda_apr_20.py , as you might be able to see , i had earlier already , partially integrated Avirup's code into that file , thanks https://github.com/digital-cognition-co-in/DigitalCognition/blob/d10c27022502b63b09311fbe43d5145ec622b15e/dc_dash/eda_apr_20.py#L26

avirupchattaraj commented 4 years ago

I saw your addition Sir. What do I need to do please explain...

avirupchattaraj commented 4 years ago

Got everything sir

RohitDhankar commented 4 years ago

@severussnape123 , as discussed on call - am closing this for now , actually my mistake should have told you that your code is already merged - no worries , as always excellent initiative on your part - regards