Closed djmaxw3ll closed 3 years ago
Thanks for reporting this @djmaxw3ll 🙂
What is the size of the collection you're trying to convert, how many tracks?
Thanks
Hi Alex, roughly 25,000
Regards
Peter Maxwell 07399 829573 0fad0940@opayq.com
From: Alex Coyle (ALZA) <> Sent: 27 July 2020 21:49 To: 0fad0940@opayq.commailto:0fad0940@opayq.com Cc: djmaxw3llmailto:0fad0940@opayq.com; Mentionmailto:mention@noreply.github.com Subject: Re: [digital-dj-tools/dj-data-converter] Fatal Error Call (#33)
Preview: Thanks for reporting this @djmaxw3ll 🙂 What is the size of t --> SPAM? CLICK to BLOCKhttps://dnt.abine.com/#/block_email/0fad0940@opayq.com/
This email is Masked using Blur - it was sent from github.com to 0fad0940@opayq.com (your reply stays Masked). To protect your privacyhttps://www.abine.com/faq.html#caniaddcc, do not forward this message, or add new recipients like CCs or BCCs.
Thanks for being a Blur customer! If you haven't yet, [ Try DeleteMe at a discount.https://joindeleteme.com/?utm_source=blur&utm_medium=email&utm_campaign=blur-offer ]
Thanks for reporting this @djmaxw3llhttps://github.com/djmaxw3ll 🙂
What is the size of the collection you're trying to convert, how many tracks?
Thanks
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/digital-dj-tools/dj-data-converter/issues/33#issuecomment-664630571, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AEWDCM7S3UYYMJXFHVZURCLR5XR4BANCNFSM4PDGUAQA.
Hi @djmaxw3ll,
Some good news, I've now got a working build that should allow larger collections to be processed more efficiently without running out of memory 🙂
Here's a very informal performance comparison between the existing NodeJS build and the new experimental GraalVM build...
alex@localhost:/mnt/d/Projects/dj-data-converter$ time nodejs ./out/cli.js -w /mnt/c/Users/alex/Documents/Native\ Instruments/Traktor\ 2.11.3/collection.nml
Conversion completed
real 3m48.585s
user 2m1.602s
sys 0m6.789s
alex@localhost:/mnt/d/Projects/dj-data-converter$ time ./target/dj-data-converter -w /mnt/c/Users/alex/Documents/Native\ Instruments/Traktor\ 2.11.3/collection.nml
Conversion completed
real 1m20.615s
user 0m38.234s
sys 0m4.089s
Looks promising, although this is just execution time of course and not memory usage. However, I'm hoping that memory usage will be lower on GraalVM, because the Clojure/Java implementation of data.xml parsing is much more efficient than the ClojureScript/NodeJS implementation, and will therefore allow larger files to be processed without running out of memory.
The next step is to modify the Azure Devops build to produce Windows and/or Mac GraalVM images for testing.
Regarding Windows and/or Mac, from the screenshot above it looks like you're on Windows, is that correct @djmaxw3ll?
Thanks!
Hi @djmaxw3ll,
I've got a Windows build for you to test with, see attached...
Please can you download, run it on your Traktor collection and let me know the result?
Thanks! 🙂