Can't convert rekordbox XML with <TEMPO> above Inizio="7200" on some tracks.

digital-dj-tools / dj-data-converter

A command-line app for converting data files to and from different DJ software formats.

MIT License

169 stars 13 forks source link

Open lord-carlos opened 2 years ago

lord-carlos commented 2 years ago

Hallo

I have a rekordbox xml with a single track that contains 129 TEMPO elements. That will cause dj-data-converter to crash. xml and edn.zip

If I delete all the TEMPO above 7200 it works.

Also both track and all the TEMPO elements have the same BPM. What are they used for if not for BPM change?

lord-carlos commented 2 years ago

I just notice it's hardcoded. https://github.com/digital-dj-tools/dj-data-converter/pull/7 Can we maybe change it to ignore TEMPO markers above 7200? (And not crash :P )

Also maybe add a parameter like -no-tempo for those who don't want them?

alza-bitz commented 1 year ago

Hi @lord-carlos I've built binaries with a candidate fix, please can you download and test to verify if the issue is fixed for your collection? https://github.com/digital-dj-tools/dj-data-converter/actions/runs/3185750575

Thanks 🙏