Fix integration with `pry`

digital-fabric / polyphony

Fine-grained concurrency for Ruby

https://www.rubydoc.info/gems/polyphony

MIT License

658 stars 17 forks source link

Closed floriandejonckheere closed 1 year ago

floriandejonckheere commented 1 year ago

An attempt at restoring the integration with pry:

Override the Readline::readline method as the original implementation was still being called
Don't block ConditionVariable#signal and #broadcast due to Queue#shift when there are no fibers waiting

Let me know if you have any thoughts.

noteflakes commented 1 year ago

Hey, did you test this? Have you tried running it with Pry or IRB?

noteflakes commented 1 year ago

I just tried it. With pry it works great. IRB's still stuck. Would you like to try fixing that as well? Thanks!

floriandejonckheere commented 1 year ago

Hi, I can take a stab at it, but it looks like it might be somewhat more complex than pry 🙂 I'll open another PR if I can manage to fix anything.