'@columns' global directive in sample valid?

digital-preservation / csv-schema

CSV Schema

http://digital-preservation.github.io/csv-schema

Mozilla Public License 2.0

100 stars 33 forks source link

'@columns' global directive in sample valid? #39

Closed mightyCelu closed 2 years ago

mightyCelu commented 2 years ago

I'm working on a parser for csv-schemas. I test this on the examples provided in example-schemas. One of the schemas uses @columns 27 as a global directive, which my parser fails on.

As far as I can tell, it is (in this case...) correct to do so, the line is not a valid GlobalDirective according to both the grammars, it should be @totalColumns 27. Am I overlooking something here?

DavidUnderdown commented 2 years ago

No, you're quite correct. Fixed by https://github.com/digital-preservation/csv-schema/commit/24fed4e8447612ff8e1b777dbd38f16e223969fe