digital-preservation / csv-validator

CSV Validation Tool and API (CSV Schema RI)
http://digital-preservation.github.io/csv-validator
Mozilla Public License 2.0
202 stars 54 forks source link

Is the "Enforce case-sensitive file path checks" option only for Windows? #462

Closed sparkhi closed 10 months ago

sparkhi commented 10 months ago

"Enforce case sensitive file path check" - how does it work, is it only for Windows? If left as unchecked, does it check paths ignoring case? how does that work on linux where the file system itself is case sensitive?

DavidUnderdown commented 10 months ago

Primarily for Windows, yes. Use case, digital archivists tend to run CSV Validator on the material on the transfer hard drive right after receipt from the transferring body. This is done on one of the Windows machines in the lab. Once we actually get to ingest, the CSV Validation tests are done in pre-ingest and ingest, both run in nix environments. There were occasions where the check on Windows passed, everything seemed OK, so we proceeded to ingest only for CSV Validation to fail in pre-ingest due to a case mismatch. So selecting the check box enforces a case sensitive check in an environment where case sensitivity isn't usually an issue. On a nix machine it doesn't actually make any difference, the operating system would report a failure anyway in the event of a case mismatch in a fileExists or checksum test.

sparkhi commented 10 months ago

Thanks @DavidUnderdown I wonder if there are users outside of TNA who want that option of case-insensitive comparison, otherwise we could simply force it to be case sensitive all the time and do away with the option from the UI / CLI

DavidUnderdown commented 10 months ago

If you're only operating on Windows, always enforcing case sensitivity is likely to cause more issues/confusion. Also the problems usually arise when the CSV file is manually edited at some point in the process, so if you're not doing that the chances are the default will be fine as well.

sparkhi commented 10 months ago

As per discussion, this is non-issue. Closing it.