search

digital-preservation / droid

DROID (Digital Record and Object Identification)
BSD 3-Clause "New" or "Revised" License
276 stars 74 forks source link

enable to expand ISO archive contained in another archive #423

Open jcharlet opened 4 years ago

jcharlet commented 4 years ago

Issue

when expanding archives, we can expand sub archives (like a ZIP in a ZIP or in a RAR), but we cannot do that for ISO archives contained in other archives.

Context

used driver doesn't provide this feature, and opensource project is inactive (no release since 2015).

See comment on uk.gov.nationalarchives.droid.core.interfaces.archive.ISOImageArchiveHandler:

        // TODO: upgrade to 2.0.2 version of java-iso-tools once released and adapt WindowReader to SeekableInput.
        // ISO images can only be instantiated from files right now, as the 2.0.1 code only supports File as
        // an input source.  The 2.0.2-SNAPSHOT code in GitHub supports a "SeekableInput" interface,
        // which we could easily adapt a WindowReader to once the 2.0.2 code is released.
        // This would allow us to process ISO files no matter where they came from (e.g. in a zip file).
        // TODO: alternatively - DROID could fork the ISO code if the project has stopped making new releases.
        // The last release was back in 2015, so it may be that the project is now basically inactive.
nishihatapalmer commented 3 years ago

The java ISO tools library has now been upgraded and should support the SeekableByteInterface. This will allow us to fix this issue.