search

digitalbazaar / bedrock-karma

Karma test framework for bedrock modules
Apache License 2.0
0 stars 0 forks source link

Re-engineer istanbul code coverage dependencies #14

Open mattcollier opened 3 years ago

mattcollier commented 3 years ago

The instanbul code coverage libraries used here are not being maintained properly. In particular, there is a JS parser module used to instrument code that is now a number of major releases behind. There are some bugs in the version of the library being used that results in valid JS code not being parsed properly. This will result in webpack failing to build the browser bundle. In cases where this is a problem, I have created this branch that disables the istanbul code coverage.

https://github.com/digitalbazaar/bedrock-karma/commit/d00f7ce1983b3871da09e69349837403812d34d7

Here's a link to the unmaintained library that needs to be replaced somehow:

https://github.com/webpack-contrib/istanbul-instrumenter-loader/issues/96

aljones15 commented 2 years ago

any idea when this will hit a release? This caused issues for me today.