search

digitalbazaar / bedrock-mongodb

Bedrock mongodb module
Apache License 2.0
2 stars 3 forks source link

Use MongoClient result from _loginUser when adding user. #74

Closed aljones15 closed 3 years ago

aljones15 commented 3 years ago

When adding a new user the new async _loginUser method now returns a fuil mongoDB client where previously it returned an object containing that client.

NOTE: this is a draft as I'm still testing the addUser functionality right now.

codecov-commenter commented 3 years ago

Codecov Report

Merging #74 (511f0da) into master (fedc685) will not change coverage. The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #74   +/-   ##
=======================================
  Coverage   60.15%   60.15%           
=======================================
  Files           4        4           
  Lines         266      266           
=======================================
  Hits          160      160           
  Misses        106      106
Impacted Files Coverage Δ
lib/index.js 56.19% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fedc685...511f0da. Read the comment docs.

dlongley commented 3 years ago

It would be nice if we had an easy way to test this -- right now it requires manual testing, IIRC.

aljones15 commented 3 years ago

@dlongley I made an issue for testing with auth here: https://github.com/digitalbazaar/bedrock-mongodb/issues/75