Open aljones15 opened 2 years ago
Merging #93 (ad561c7) into mongo-driver-4-rc (1b4c0e6) will increase coverage by
2.40%
. The diff coverage is50.00%
.
@@ Coverage Diff @@
## mongo-driver-4-rc #93 +/- ##
=====================================================
+ Coverage 87.08% 89.48% +2.40%
=====================================================
Files 8 8
Lines 813 742 -71
=====================================================
- Hits 708 664 -44
+ Misses 105 78 -27
Impacted Files | Coverage Δ | |
---|---|---|
lib/authn.js | 83.72% <ø> (+6.67%) |
:arrow_up: |
lib/index.js | 81.85% <0.00%> (+0.71%) |
:arrow_up: |
lib/test.config.js | 100.00% <ø> (ø) |
|
lib/urls.js | 91.48% <ø> (+6.30%) |
:arrow_up: |
lib/config.js | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
This was tested locally with a server with authentication on. The following was the result:
Additionally I tested what happens if someone sets
connectOptions.auth
config.mongodb.username
config.mongodb.password
./lib/authn.js
to./lib/connect.js
urls.create
PR Mystery that needs to be solved:
auth
object, but the ci tests failed which suggests there is an edge case where theauth
object is failing when the authSource is not the database being connected to.Resolves this issue, by removing auth defaults: https://github.com/digitalbazaar/bedrock-mongodb/issues/54