search

digitalbazaar / bedrock-vue-pdf417

Other
1 stars 0 forks source link

What is the proper handling for `@bedrock/web-fontawesome` dependency #38

Open mattcollier opened 6 months ago

mattcollier commented 6 months ago

https://github.com/digitalbazaar/bedrock-vue-pdf417/blob/main/components/Buttons.vue#L42

The button here and perhaps other places reference font awesome classes/icons. Although this module lists @bedrock/web-fontawesome as a peerDependency it does not import the module directly here.

It seems to me that this module should import the fontawesome library directly here and if that's the case, then it should also be listed as a regular dependency. Is all that correct?

jameseaster commented 6 months ago

Great question, I'm guessing an app that wants to use bedrock-vue-pdf417 would have to set up its index.js file similar to test/components/index.js and import bedrock-web-fontawesome there?