search

digitalbazaar / bedrock-webpack

Bedrock webpack module.
Apache License 2.0
0 stars 2 forks source link

Specify `resolve.symlinks` option. #3

Closed mattcollier closed 7 years ago

mattcollier commented 7 years ago

Allows symlinked modules to be processed properly.

@davidlehn I know you're familiar with this issue, will you confirm this fix?

This solution came from: https://github.com/babel/babel-loader/issues/149#issuecomment-312622067

davidlehn commented 7 years ago

I'm not sure I've had this exact problem. Maybe something similar that I hacked around? It's kind of hard to tell from that other issue and webpack docs if that flag should be true or false. If false fixes it, we can revisit later if something else breaks.

mattcollier commented 7 years ago

@davidlehn Perhaps I can jog your memory. The issue here is that if you symlink a front end dependency such as bedrock-angular-authn-password and then attempt the optimize, the optimize fails due to error: https://gist.github.com/mattcollier/46ed05ea80d7f3da24edce0de8437a35

With this patch, the optimization is successful, and the symlinked module functions properly in minified mode.