digitalbazaar / cborld

A Javascript CBOR-LD processor for web browsers and Node.js apps.
https://json-ld.github.io/cbor-ld-spec/
BSD 3-Clause "New" or "Revised" License
21 stars 17 forks source link

Add a failing test to guide 2.0 fixes. #16

Closed dmitrizagidulin closed 4 years ago

dmitrizagidulin commented 4 years ago

Adding a failing test to help guide the various 2.0 fixes (https://github.com/digitalbazaar/cborld/issues/14 etc)

codecov-io commented 4 years ago

Codecov Report

Merging #16 into main will increase coverage by 31.63%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #16       +/-   ##
===========================================
+ Coverage   26.63%   58.26%   +31.63%     
===========================================
  Files          16       16               
  Lines         368      369        +1     
===========================================
+ Hits           98      215      +117     
+ Misses        270      154      -116     
Impacted Files Coverage Δ
lib/context.js 75.00% <100.00%> (+55.64%) :arrow_up:
lib/codecs/UrlCodec.js 36.36% <0.00%> (+12.12%) :arrow_up:
lib/encode.js 52.27% <0.00%> (+22.72%) :arrow_up:
lib/decode.js 67.24% <0.00%> (+31.03%) :arrow_up:
lib/codecs/MultibaseCodec.js 40.00% <0.00%> (+40.00%) :arrow_up:
lib/codecs/ContextCodec.js 78.78% <0.00%> (+57.57%) :arrow_up:
lib/codec.js 80.70% <0.00%> (+61.40%) :arrow_up:
lib/codecs/SimpleTypeCodec.js 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 73a6e00...fc233b3. Read the comment docs.

dmitrizagidulin commented 4 years ago

@JSAssassin - looks great, thank you!

One change request - can you rename ageOver to overAge (this initial PR was added before we did the rename everywhere); you may need to update the corresponding cborldBytes array in the test.

dmitrizagidulin commented 4 years ago

@JSAssassin - thanks! 👍 from me on this PR.