digitalbazaar / did-method-key

A did-io driver for the DID "key" method
Other
25 stars 10 forks source link

Refactor implementation of did:key. #34

Closed msporny closed 3 years ago

msporny commented 3 years ago

Changed

This is being driven by the ezcap work, I'm trying to get to a nice pattern to create the ezcap client:

const baseUrl = 'https://zcap.example/';
const {didDocument, keyPairs} = await didKeyDriver.generate();
const {invocationSigner, delegationSigner} = getCapabilitySigners({didDocument, keyPairs});
const zcapClient = new ZcapClient({baseUrl, invocationSigner, delegationSigner});
codecov-io commented 3 years ago

Codecov Report

Merging #34 (83ffa4d) into master (5d28b0c) will increase coverage by 4.61%. The diff coverage is 97.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #34      +/-   ##
==========================================
+ Coverage   91.30%   95.91%   +4.61%     
==========================================
  Files           2        2              
  Lines          46       49       +3     
==========================================
+ Hits           42       47       +5     
+ Misses          4        2       -2     
Impacted Files Coverage Δ
lib/Driver.js 95.65% <97.05%> (+4.95%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d28b0c...83ffa4d. Read the comment docs.

dmitrizagidulin commented 3 years ago

This PR has been refactored/re-implemented in PR #35, I propose we close this one.