search

digitalbazaar / did-method-key

A did-io driver for the DID "key" method
Other
25 stars 10 forks source link

Refactor to match latest did-io and 2020 suites. #35

Closed dmitrizagidulin closed 3 years ago

dmitrizagidulin commented 3 years ago

Refactors to match latest versions of did-io (see PR https://github.com/digitalbazaar/did-io/pull/50) and 2020 suites.

Also, moves the caching layer over to CachingResolver in did-io.

codecov-io commented 3 years ago

Codecov Report

Merging #35 (7c6fef6) into master (5d28b0c) will increase coverage by 7.64%. The diff coverage is 98.94%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #35      +/-   ##
==========================================
+ Coverage   91.30%   98.94%   +7.64%     
==========================================
  Files           2        4       +2     
  Lines          46       95      +49     
==========================================
+ Hits           42       94      +52     
+ Misses          4        1       -3
Impacted Files Coverage Δ
lib/DidKeyDriver.js 97.22% <97.22%> (ø)
lib/index.js 100.00% <100.00%> (ø)
lib/main.js 100.00% <100.00%> (ø)
test/driver.spec.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5d28b0c...7c6fef6. Read the comment docs.

mattcollier commented 3 years ago

@dmitrizagidulin is this ready for review, no reviewers have been selected which means it wasn't on the radar for folks looking for review requested.

mattcollier commented 3 years ago

The readme section needs to be updated to reflect the 2020 key variety:

https://github.com/digitalbazaar/did-method-key-js/blob/v1.x/README.md#usage

dmitrizagidulin commented 3 years ago

@mattcollier - it still needs the README updated to reflect the new changes. After that, I was gonna request reviewers.