digitalbazaar / did-method-key

A did-io driver for the DID "key" method
Other
25 stars 10 forks source link

Add did key spec 7 validators #47

Open aljones15 opened 2 years ago

aljones15 commented 2 years ago

Addresses: https://github.com/digitalbazaar/did-method-key/issues/46 Also Addresses: https://github.com/digitalbazaar/did-method-key/issues/48

Features:

To Do:

Sister PRs: https://github.com/digitalbazaar/did-io/pull/63 https://github.com/digitalbazaar/bedrock-did-io/pull/14 https://github.com/digitalbazaar/bedrock-did-resolver-http/pull/3

codecov-commenter commented 2 years ago

Codecov Report

Merging #47 (3c84f1d) into main (ca4b973) will decrease coverage by 1.37%. The diff coverage is 93.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #47      +/-   ##
==========================================
- Coverage   96.38%   95.01%   -1.37%     
==========================================
  Files           2        4       +2     
  Lines         304      562     +258     
==========================================
+ Hits          293      534     +241     
- Misses         11       28      +17     
Impacted Files Coverage Δ
lib/validators.js 90.34% <90.34%> (ø)
lib/verificationMethods.js 92.30% <92.30%> (ø)
lib/DidKeyDriver.js 98.00% <100.00%> (+1.87%) :arrow_up:
lib/index.js 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dlongley commented 1 year ago

This PR is doing too many things at once -- and some of them no longer matter (like node 14 support, etc.) due to concurrent advances elsewhere. We should try and break off the validation pieces into their own separate PR and so on.