search

digitalbazaar / ecdsa-sd-2023-cryptosuite

A selective disclosure Data Integrity cryptosuite based on ECDSA for use with jsonld-signatures.
BSD 3-Clause "New" or "Revised" License
14 stars 3 forks source link

Add support to confirm base proofs #31

Closed dlongley closed 2 months ago

dlongley commented 2 months ago

The code here needs some slight reworking to add a createConfirmCryptosuite that is used to confirm base proofs -- to be distinguished from createVerifyCryptosuite which is used to verify derived proofs.

dlongley commented 2 months ago

Related #30.

codecov-commenter commented 2 months ago

Codecov Report

Attention: Patch coverage is 93.54839% with 8 lines in your changes missing coverage. Please review.

Project coverage is 90.80%. Comparing base (00f1698) to head (77cf7bf). Report is 9 commits behind head on main.

Files Patch % Lines
lib/confirm.js 95.18% 4 Missing :warning:
lib/proofValue.js 85.18% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #31 +/- ## ========================================== + Coverage 90.05% 90.80% +0.74% ========================================== Files 7 8 +1 Lines 694 794 +100 ========================================== + Hits 625 721 +96 - Misses 69 73 +4 ``` | [Files](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar) | Coverage Δ | | |---|---|---| | [lib/index.js](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?src=pr&el=tree&filepath=lib%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL2luZGV4Lmpz) | `100.00% <100.00%> (ø)` | | | [lib/sign.js](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?src=pr&el=tree&filepath=lib%2Fsign.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL3NpZ24uanM=) | `92.17% <100.00%> (+0.13%)` | :arrow_up: | | [lib/verify.js](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?src=pr&el=tree&filepath=lib%2Fverify.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL3ZlcmlmeS5qcw==) | `96.69% <100.00%> (+0.08%)` | :arrow_up: | | [lib/confirm.js](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?src=pr&el=tree&filepath=lib%2Fconfirm.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL2NvbmZpcm0uanM=) | `95.18% <95.18%> (ø)` | | | [lib/proofValue.js](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?src=pr&el=tree&filepath=lib%2FproofValue.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL3Byb29mVmFsdWUuanM=) | `84.92% <85.18%> (+0.63%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar). Last update [5355b09...77cf7bf](https://app.codecov.io/gh/digitalbazaar/ecdsa-sd-2023-cryptosuite/pull/31?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar).