search

digitalbazaar / ed25519-verification-key-2020

Javascript library for generating and working with Ed25519VerificationKey2020 key pairs, for use with crypto-ld.
BSD 3-Clause "New" or "Revised" License
3 stars 10 forks source link

Add SUITE_CONTEXT property, 'revoked' export tests. #9

Closed dmitrizagidulin closed 3 years ago

dmitrizagidulin commented 3 years ago

See also corresponding PR https://github.com/digitalbazaar/crypto-ld/pull/58

mattcollier commented 3 years ago

It appears the key class needs to implement fromKeyDocument

https://github.com/digitalbazaar/crypto-ld/blob/658a6fafb4c85995a16948675e1421663cca4a65/lib/CryptoLD.js#L117-L118

mattcollier commented 3 years ago

It appears the key class needs to implement fromKeyDocument

https://github.com/digitalbazaar/crypto-ld/blob/658a6fafb4c85995a16948675e1421663cca4a65/lib/CryptoLD.js#L117-L118

OIC, it looks like there's a dependency issue here, this branch needs to be made on the cryptold branch to pick up the superclass method: https://github.com/digitalbazaar/crypto-ld/pull/58/files#diff-8cff1a81f521d98b56a06fb28fd4df342c3d111fbe7a0ef0f8e9441aadb13510R71

I'm adding that dep update now.

dmitrizagidulin commented 3 years ago

@mattcollier

OIC, it looks like there's a dependency issue here

Yeah, exactly. thanks!!