search

digitalbazaar / eslint-config-digitalbazaar

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Issues related to use of backtick #15

Closed mattcollier closed 5 years ago

mattcollier commented 5 years ago

https://github.com/digitalbazaar/eslint-config-digitalbazaar/blob/master/index.js#L50

That rule doesn't like

const string = `imastring`;

but it's ok with

const string = `imastring${withvar}`;

and it doesn't like:

const string = `'quotedstring' is a thing.`;
davidlehn commented 5 years ago

https://eslint.org/docs/rules/quotes Probably need to add one or more of the options like allowTemplateLiterals?

aljones15 commented 5 years ago

added allowTemplateLiterals to the pending PR so try it @mattcollier and see if it works.

aljones15 commented 5 years ago

@mattcollier is this issue resolved now?

mattcollier commented 5 years ago

Yes, ty.