search

digitalbazaar / eslint-config-digitalbazaar

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Use 'brace-style' of '1tbs'. #31

Closed davidlehn closed 4 years ago

davidlehn commented 4 years ago

https://eslint.org/docs/rules/brace-style

When doing a code review it surprised @dlongley that we didn't already check.

aljones15 commented 4 years ago

This is usually caught by intentation errors:

 4:1  error  Opening curly brace does not appear on the same line as controlling statement  brace-style
  4:1  error  Expected indentation of 2 spaces but found 0                                   indent

This will lead to some minor issues with line length where maybe it would have been easier to drop the curly brace to the next line, but I think in most cases this will be fine and in the line length case your code could probably be broken into smaller functions anyways.

aljones15 commented 4 years ago

@mattcollier I can't do releases yet... or can I so if you are happy with this addition I'm ok with it and we could bump the release. I probably should be handling releases for this at this point.