Closed aljones15 closed 3 years ago
There is an existing rule: https://github.com/digitalbazaar/eslint-config-digitalbazaar/blob/master/index.js#L14
And an old issue: https://github.com/digitalbazaar/eslint-config-digitalbazaar/issues/17
-1. I'm not ok with making it an error to have no dangling comma.
I'm going to go ahead and close this provided we are at consensus that we are ok with a dangling comma on multi-line, but it is also ok to not have a dangling comma if the dev chooses.
Yup, I think that's the consensus we have (i.e., that we don't have consensus to use/not use dangling commas on multilines, so we allow devs to choose).
@mattcollier do you agree with @dlongley here? if so I'll close this.
48 hours is enough time. I'm closing this and assuming that as a company we allow developers to have dangling commas or not at their discretion. I also agree with that rule.
https://eslint.org/docs/rules/comma-dangle
When I joined DB I was told not to use dangling commas like this:
however it appears this might not be the consensus on this issue.
Please discuss, and thumbs up if you are ok with this new rule: