Add module preset. - Githubissues

davidlehn commented 2 years ago

This adds a "module" preset, for use with any ES Modules.

It pulls in eslint-plugin-unicorn just for their prefer-module rules. I'm not sure if this adds too much weight, but it was easier for now than trying to replicate just the module parts.
The parserOptions.ecmaVersion: 'latest' was copied from somewhere and I suspect that could just be a version or year to avoid allow too new syntax. I'm not sure what value is appropriate here.
I suspect we may want some local rule adjustments for our projects which is why this wrapper preset was made instead of just using prefer-module directly in all of our modules.

davidlehn commented 2 years ago

Updated to remove direct unicorn dep. Can add it everywhere like the other modes. This pattern doesn't seem very good but it's consistent now.

aljones15 commented 2 years ago

@davidlehn has this been tested anywhere? what happens in the bedrock libs that now use modules?

davidlehn commented 2 years ago

@davidlehn has this been tested anywhere? what happens in the bedrock libs that now use modules?

Latest test is https://github.com/digitalbazaar/bedrock-web-account/pull/27. I had hoped to use this on all the converted modules but that project got ahead of this patch. Still useful to add to avoid non-module regressions later. The intent would be to add this to all our module packages.

digitalbazaar / eslint-config-digitalbazaar

Add module preset. #55