digitalbazaar / eslint-config-digitalbazaar

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Set env 2022 #57

Closed aljones15 closed 2 years ago

aljones15 commented 2 years ago

This removes the need to set ecmaVersion while also updating the globals that eslint thinks are ok.

dlongley commented 2 years ago

Using eslint 8 needs to be tested against existing modules like bedrock-account where errors that link to this issue occur: https://github.com/eslint/eslint/issues/14745

aljones15 commented 2 years ago

Using eslint 8 needs to be tested against existing modules like bedrock-account where errors that link to this issue occur: eslint/eslint#14745

17:1 warning This rule cannot yet be supported for ESLint 8; you should either downgrade to ESLint 7 or disable this rule. The possibility for ESLint 8 support is being tracked at https://github.com/eslint/eslint/issues/14745 jsdoc/check-examples

looks like jsdoc/check-examples needs to be disabled even with the latest eslint-plugin-jsdoc this error persists. We don't use jsdoc/check-examples much so this might not be a big deal.

davidlehn commented 2 years ago

This should be addressed sooner rather than later.

davidlehn commented 2 years ago

I think the best action here is to comment out the jsdoc/check-examples rule for now until the related bug is fixed. It seems like the other checks are working fine. So we're just losing the rare doc example linting for now.

If we set env.2022=true, then ecmaVersion is set to 13 (2022). Does it make sense to set ecmaVersion here at all? https://eslint.org/docs/user-guide/configuring/language-options#specifying-environments

Proposed update in https://github.com/digitalbazaar/eslint-config-digitalbazaar/pull/58.

dlongley commented 2 years ago

Seems like we should close this in favor of #58.

aljones15 commented 2 years ago

Closing in favor of https://github.com/digitalbazaar/eslint-config-digitalbazaar/pull/58

davidlehn commented 2 years ago

Reopening to cascade the other branch through here.