search

digitalbazaar / eslint-config-digitalbazaar

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Set env 2022 update. #58

Closed davidlehn closed 2 years ago

davidlehn commented 2 years ago
aljones15 commented 2 years ago

@davidlehn has this been tested on any modules? Maybe we should list all the packages that were tested. bedrock-account was an issue before this and the primary concern is that there might be more issues than just check-examples.

davidlehn commented 2 years ago

I'm not sure how to properly easily test, but did some ad-hoc testing. Some variation of the below shows just the expected issues due to not using proper per-package configs. I didn't see anything unexpected but maybe missed something in the noise. Add/remove --config with index.js, jsdoc.js, module.js.

cd eslint-config-digitalbazaar
npm i --no-save eslint eslint-plugin-vue eslint-plugin-jsdoc eslint-plugin-unicorn
./node_modules/.bin/eslint --no-eslintrc --ignore-pattern node_modules --ext .js,.vue,.cjs,.mjs --config index.js --env mocha,node,es2022 [dir(s)-to-test...]

If you have everything checked out, probably easier to just loop through all dirs and run tests, but I don't have the space.

I'm going to move forward with this. It will be a major bump so packages can just update as we go and we'll fix problems and adjust rules as needed.