search

digitalbazaar / eslint-config-digitalbazaar

BSD 3-Clause "New" or "Revised" License
2 stars 1 forks source link

Use `unicorn/prefer-node-protocol` in 'module'. #59

Closed davidlehn closed 2 years ago

davidlehn commented 2 years ago

I still wasn't sure if this was a good idea. I had chatted about it elsewhere, but I guess didn't comment here. The node: prefix has nothing to do with modules. It also didn't seem this should be forced on everything in our main rules config. I didn't know where it should go. As we are adding the module rules to many packages, this is going to effect a lot of code by force. I had actually just started adding the rule directly to projects while this PR was pending.

Does anyone else have an opinion on this?

davidlehn commented 2 years ago

If no one else has an opinion, should we revert this? I still don't know where it should go and have just been adding the rule by itself everywhere.

@aljones15 You merged this, what are your thoughts?

aljones15 commented 2 years ago

go ahead and revert this and then we can release.