search

digitalbazaar / http-client

An opinionated, isomorphic HTTP client.
BSD 3-Clause "New" or "Revised" License
2 stars 7 forks source link

Support node18 #26

Closed dlongley closed 2 years ago

dlongley commented 2 years ago

This is being tested in a number of projects to determine if the changes are sufficient.

dlongley commented 2 years ago

Looks like we can't get to full node 18 support yet because we can't set cookie headers in requests. The issue of cookies w/ undici fetch is under discussion over here: https://github.com/nodejs/undici/issues/1262

codecov-commenter commented 2 years ago

Codecov Report

Merging #26 (6270975) into main (2a47f7b) will decrease coverage by 12.39%. The diff coverage is 56.33%.

@@             Coverage Diff             @@
##             main      #26       +/-   ##
===========================================
- Coverage   95.27%   82.87%   -12.40%     
===========================================
  Files           2        3        +1     
  Lines         148      216       +68     
===========================================
+ Hits          141      179       +38     
- Misses          7       37       +30
Impacted Files Coverage Δ
lib/agentCompatibility.js 49.05% <49.05%> (ø)
lib/httpClient.js 93.46% <77.77%> (-1.47%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a47f7b...6270975. Read the comment docs.