Implement createDigestString() method.

digitalbazaar / http-signature-header

BSD 3-Clause "New" or "Revised" License

8 stars 2 forks source link

Implement createDigestString() method. #19

Closed dmitrizagidulin closed 5 years ago

dmitrizagidulin commented 5 years ago

Extracted from https://github.com/digitalbazaar/http-signature-zcap-invoke/blob/master/main.js#L35

WIP, todo:

[ ] Find an isomorphic way to base64-encode strings (our base64url-universal does not expose non-url encoding)
[ ] Find some test strings for multihash digest?

dmitrizagidulin commented 5 years ago

Hmmm except isomorphic-webcrypto requires Node 12. Maybe I need to put this into a separate npm package?

aljones15 commented 5 years ago

@dlongley @dmitrizagidulin this does not break any existing http-signatures-test-suite tests (except for the already failing ones for created and expires). just not sure on if we want to use isomorphic-webcrypto.

p.s. only runs in node 12.

dlongley commented 5 years ago

-1 to this PR without some design changes. We've avoided putting any crypto stuff into this library thus far and I'd like us to explore continuing that. The simplest approach would be to just put this new stuff into its own module, like http-signature-digest-header or similarly named.

dmitrizagidulin commented 5 years ago

@dlongley ok, copy that, I wasn't sure about that part. I'll move it to a different repo.

dlongley commented 5 years ago

@dmitrizagidulin -- Thanks! Sorry about that.

dmitrizagidulin commented 5 years ago

Extracted to https://github.com/digitalbazaar/http-signature-digest/pull/1, closing.