search

digitalbazaar / http-signature-header

BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Remove hash from hs 2019 #28

Closed aljones15 closed 3 years ago

aljones15 commented 4 years ago

This PR does the following:

  1. Removes the SHA-512 hash from hs2019 http signature algorithm (this is to better match zcap-verify)
  2. Adds comments to the code to clarify a hastily written library
  3. Improvdes code quality with better variables names and methods and stuff like that.
codecov-io commented 3 years ago

Codecov Report

Merging #28 (e124b45) into master (8c9fada) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files           3        3           
  Lines         219      219           
=======================================
  Hits          203      203           
  Misses         16       16

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8c9fada...e124b45. Read the comment docs.