digitalbazaar / http-signature-header

BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Check for signature param in request.params.signature. #29

Closed aljones15 closed 3 years ago

aljones15 commented 3 years ago

Should fix the signature parameter error:

https://github.com/digitalbazaar/http-signature-header/issues/20

I think this is a redundant check as we already throw in parseRequest when there is no parsed.params.signature so this is a draft PR as I'm wondering if I should drop this validator from the binary and use the one from the library instead. Also sorry about the low quality of code in the binary.

https://github.com/digitalbazaar/http-signature-header/blob/f88cf51531447569c91e0e01bbaadb92ba3aff64/lib/index.js#L301-L303

EDIT: THIS CAN WAIT TILL AFTER THE HOLIDAYS NO RUSH HERE.

codecov-io commented 3 years ago

Codecov Report

Merging #29 (1c91c3b) into master (f88cf51) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #29   +/-   ##
=======================================
  Coverage   92.69%   92.69%           
=======================================
  Files           3        3           
  Lines         219      219           
=======================================
  Hits          203      203           
  Misses         16       16           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f88cf51...1c91c3b. Read the comment docs.