search

digitalbazaar / http-signature-header

BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Properly annotate breaking changes for 2.x release #41

Closed mattcollier closed 3 years ago

mattcollier commented 3 years ago

https://github.com/digitalbazaar/http-signature-header/blob/master/CHANGELOG.md#200---2021-02-25

None of the changes in 2.x are labelled as breaking. Since it was a major release, I would expect that at least one of them is a breaking change.

davidlehn commented 3 years ago

Fixed in https://github.com/digitalbazaar/http-signature-header/pull/42. Is a release needed for this?