search

digitalbazaar / http-signature-header

BSD 3-Clause "New" or "Revised" License
8 stars 2 forks source link

Allow signature headers #46

Open aljones15 opened 3 years ago

aljones15 commented 3 years ago

Addresses the following issues: https://github.com/digitalbazaar/http-signature-header/issues/38 https://github.com/digitalbazaar/http-signature-header/issues/43

Changes:

  1. deletes the parseRequest file from tests.
  2. Implements tests from parseRequest as unit tests
  3. adds support for non Authorization headers

Questions:

  1. by supporting non-authorization headers we might be making a breaking change for other implementations.
codecov-commenter commented 3 years ago

Codecov Report

Merging #46 (4b5067e) into master (f86b0e8) will increase coverage by 1.30%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   93.19%   94.49%   +1.30%     
==========================================
  Files           3        3              
  Lines         235      236       +1     
==========================================
+ Hits          219      223       +4     
+ Misses         16       13       -3
Impacted Files Coverage Δ
lib/index.js 94.29% <100.00%> (+1.34%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f86b0e8...4b5067e. Read the comment docs.