digitalbazaar / http-signature-zcap-invoke

A library for invoking Authorization Capabilities via HTTP signatures

BSD 3-Clause "New" or "Revised" License

2 stars 3 forks source link

Set default unix time stamps for created & expires http-signature-header parameters #12

Closed aljones15 closed 3 years ago

aljones15 commented 4 years ago

Sets defaults for created & expires for http-signature-header. These parameters can be passed in to allow for better testing.

Sister PR: https://github.com/digitalbazaar/http-signature-zcap-verify/pull/19

OR13 commented 3 years ago

This PR is still blocking the creation of stable EDV test vectors.

codecov-io commented 3 years ago

Codecov Report

Merging #12 (8106e6f) into master (7433d1d) will decrease coverage by 2.21%. The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   97.67%   95.45%   -2.22%     
==========================================
  Files           2        2              
  Lines          43       44       +1     
==========================================
  Hits           42       42              
- Misses          1        2       +1

Impacted Files	Coverage Δ
main.js	`95.34% <66.66%> (-2.28%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7433d1d...8106e6f. Read the comment docs.

aljones15 commented 3 years ago

NOTE: This PR needs the next release of http-signature-header first.

aljones15 commented 3 years ago

TY. I've been working with this code in new zcap work in bedrock-kms-http. Noting there are not changelog entries included in this PR. Perhaps it is already well known that these are breaking changes.

this was not ready for release until http-signature-header ^2.0.0 released yesterday. I added the CHANGELOG here: https://github.com/digitalbazaar/http-signature-zcap-invoke/pull/12/commits/8106e6fa6200f18cbbaac3ce136b1d34e87c2fdd

However we do need to discuss how to handle this release as having http-signature-header 1.0.0 on the backend and 2.0.0 on the front end and vice versa results in signatures failing to verify.