search

digitalbazaar / jsonld.js

A JSON-LD Processor and API implementation in JavaScript
https://json-ld.org/
Other
1.66k stars 195 forks source link

Fix term mapping of `@reverse`. #370

Closed davidlehn closed 4 years ago

davidlehn commented 4 years ago

Please check. I'm making tests pass without proper understanding of how this should be working. Should there be some warning here or is the "ignore" behavior itself important?

gkellogg commented 4 years ago

Please check. I'm making tests pass without proper understanding of how this should be working. Should there be some warning here or is the "ignore" behavior itself important?

The "ignore" behavior is important, as it affects processing flow. You should also generate a warning.

The bug I had in my code was I checked after expanding it as an IRI, which led to a failure, which is not right. With the ignore/warning, you drop out of the create term definition for that term and a term doesn't get created.