search

digitalbazaar / jsonld.js

A JSON-LD Processor and API implementation in JavaScript
https://json-ld.org/
Other
1.66k stars 195 forks source link

Please replace request #420

Closed guimard closed 3 years ago

guimard commented 3 years ago

Hi,

request has been deprecated, could you replace it by another library ?

Cheers, Xavier

aljones15 commented 3 years ago

I assigned to me, I will try to replace request with ky ASAP.

@dlongley @davidlehn do we want to replace request with ky or axios or another option?

dlongley commented 3 years ago

@aljones15, we can use @digitalbazaar/http-client.

aljones15 commented 3 years ago

Please note this issue is also related to: https://github.com/digitalbazaar/jsonld.js/issues/200

Which is to replace the documentLoader with a solution that uses the browser's fetch api such as axios. In our case we will be using https://github.com/digitalbazaar/http-client which in turn uses ky.

We also need to fix the tests for the documentLoaders:

  1. test should rely on an express server we start at the beginning of the test suite
  2. tests should attempt to resolve contexts/ jsonld documents served as static assets from the express instance.
dmitrizagidulin commented 3 years ago

Just to update: This is still on our radar, will get to this as time permits.

davidlehn commented 3 years ago

Fixed in 5.0.0.