digitalbazaar / jsonld.js

A JSON-LD Processor and API implementation in JavaScript
https://json-ld.org/
Other
1.66k stars 195 forks source link

Update rdf-canonize. #427

Closed davidlehn closed 3 years ago

davidlehn commented 3 years ago

@dlongley setImmediate polyfill was removed in rdf-canonize and now karma tests fail. Should that be restored there or should the webpack/karma setups be changed to use the builtin polyfill?

dlongley commented 3 years ago

The webpack/karma setups should be changed to use the builtin polyfill.

davidlehn commented 3 years ago

Ok. Such polyfills are removed in webpack 5, so when that migration happens we'll have to use https://github.com/yuzujs/setImmediate directly.

davidlehn commented 3 years ago

Upon further consideration, going to go with the setimmediate package directly in rdf-canonize to hopefully simplify things so packages like this don't have to do anything and will be ready for webpack v5.