digitalbazaar / vc

W3C Verifiable Credentials implementation in JavaScript
BSD 3-Clause "New" or "Revised" License
177 stars 52 forks source link

exclude issuanceDate check on issuance #145

Closed F-Node-Karlsruhe closed 1 year ago

F-Node-Karlsruhe commented 1 year ago

Adding a mode to _checkCredential() resolving issue https://github.com/digitalbazaar/vc/issues/144

dmitrizagidulin commented 1 year ago

As another data point, in our fork, we do this in a slightly finer-grained way:

https://github.com/digitalcredentials/vc/blob/main/lib/index.js#L667

F-Node-Karlsruhe commented 1 year ago

As another data point, in our fork, we do this in a slightly finer-grained way:

https://github.com/digitalcredentials/vc/blob/main/lib/index.js#L667

57 commits ahead, 84 commits behind but with more activity than this repository. Might it be wise to switch to the digitalcredentials implementation?

dlongley commented 1 year ago

@F-Node-Karlsruhe,

Sorry about the delay, I think wires got crossed on who would merge and move this ahead.

dlongley commented 1 year ago

@F-Node-Karlsruhe,

This has been released in v6.0.2.