digitalbazaar / vc

W3C Verifiable Credentials implementation in JavaScript
BSD 3-Clause "New" or "Revised" License
177 stars 52 forks source link

VC 2.0 Release Canidate #148

Closed aljones15 closed 2 months ago

aljones15 commented 1 year ago

Features:

  1. Issues and Verifies VCs using the 1.0 and 2.0 VC Data Models
  2. Has integration tests for VCs using both models
  3. Has validators for validUntil and validFrom
  4. Updates the timestamp validator to use the XML standard from the spec
  5. includes an expanded suite with timestamp tests

NOTE: new features in the VC 2.0 release should branch from this PR unless they build on another feature in a sister PR.

TODO:

Addresses: https://github.com/digitalbazaar/vc/issues/149#issuecomment-2192051465

JSAssassin commented 1 year ago

@aljones15 IMO we should drop support for Node 14 and 16 and that can be addressed in a separate PR.

aljones15 commented 1 year ago

@aljones15 IMO we should drop support for Node 14 and 16 and that can be addressed in a separate PR.

awesome thanks for letting me, node 14 tests are failing probably because of the branches.

OR13 commented 1 year ago

When this get's merged we will want to update the various plugins that build examples.

aljones15 commented 1 year ago

When this get's merged we will want to update the various plugins that build examples.

@OR13 this branch was used for the test suite for VC 2.0, but as that spec is still in progress, we might not release this build of this library. This PR also still lacks a few VC 2.0 features such as validUntil and validFrom. So this PR is not currently prioritized to my knowledge for merge or release.

codecov-commenter commented 10 months ago

Codecov Report

Attention: Patch coverage is 90.85366% with 30 lines in your changes missing coverage. Please review.

Project coverage is 90.46%. Comparing base (be05032) to head (203d698).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ========================================== + Coverage 88.66% 90.46% +1.79% ========================================== Files 4 5 +1 Lines 812 1059 +247 ========================================== + Hits 720 958 +238 - Misses 92 101 +9 ``` | [Files](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar) | Coverage Δ | | |---|---|---| | [lib/contexts/index.js](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?src=pr&el=tree&filepath=lib%2Fcontexts%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL2NvbnRleHRzL2luZGV4Lmpz) | `100.00% <100.00%> (ø)` | | | [lib/helpers.js](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?src=pr&el=tree&filepath=lib%2Fhelpers.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL2hlbHBlcnMuanM=) | `92.39% <92.39%> (ø)` | | | [lib/index.js](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?src=pr&el=tree&filepath=lib%2Findex.js&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar#diff-bGliL2luZGV4Lmpz) | `90.70% <89.68%> (+1.64%)` | :arrow_up: | ------ [Continue to review full report in Codecov by Sentry](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?dropdown=coverage&src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar). Last update [be05032...203d698](https://app.codecov.io/gh/digitalbazaar/vc/pull/148?dropdown=coverage&src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=digitalbazaar).
aljones15 commented 2 months ago

@davidlehn obviously leave the branch update-vc-2.0 so other builds still work with it for now.