Closed aljones15 closed 7 months ago
:exclamation: No coverage uploaded for pull request base (
update-vc-2.0@9ff44fe
). Click here to learn what that means. The diff coverage isn/a
.
@aljones15 it looks like this PR has moved (or is moving) well beyond validUntil
and validBefore
. Is that correct? If so, we should relabel the PR at least.
I'm also a bit concerned about us ending up with one massive PR to review. Can we do more, smaller PRs against a non-main
branch (as this one is against update-vc-2.0
)? That would make reviews much faster, safer, and more sane. 😃
I will refrain from merging any further PRs into this PR, but as this PR and the other PR: https://github.com/digitalbazaar/vc/pull/170 had both been approved it seemed safe to merge the two.
As for this PR moving beyond validUntil
& validBefore
that was not intentional, but the feature making credentialStatus.id optional branched from the validUntil branch so it couldn't be aimed at the core VC 2.0 branch/PR.
I will refrain from merging any further PRs into this PR, but as this PR and the other PR: #170 had both been approved it seemed safe to merge the two.
As for this PR moving beyond
validUntil
&validBefore
that was not intentional, but the feature making credentialStatus.id optional branched from the validUntil branch so it couldn't be aimed at the core VC 2.0 branch/PR.
Mostly, my aim is to keep topics clear...and now it's pretty muddied what's going on.
Also, as @JSAssassin mentioned earlier, the fields are validFrom
and validUntil
--and we should change this PR to match.
Thanks!
@BigBlueHat @davidlehn please double check this as this is your last chance before merge into update-vc-2.0
.
Features:
credentialStatus
check changes from herecredentialStatus.id
optionalcredentialStatus.id
is present it must be a URL.