search

digitalbazaar / web-ledger-client

An implementation of a a Web Ledger client
BSD 3-Clause "New" or "Revised" License
5 stars 2 forks source link

Convert to module (ESM). #30

Closed davidlehn closed 2 years ago

davidlehn commented 2 years ago
codecov-commenter commented 2 years ago

Codecov Report

Merging #30 (888d53e) into main (57b02df) will increase coverage by 6.17%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
+ Coverage   82.53%   88.70%   +6.17%     
==========================================
  Files           4        4              
  Lines         126      434     +308     
==========================================
+ Hits          104      385     +281     
- Misses         22       49      +27
Impacted Files Coverage Δ
lib/WebLedgerClient.js 87.93% <100.00%> (+6.57%) :arrow_up:
lib/WebLedgerClientError.js 100.00% <100.00%> (ø)
lib/constants.js 100.00% <100.00%> (ø)
lib/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 57b02df...888d53e. Read the comment docs.

mattcollier commented 2 years ago

@davidlehn what is the status here, the http-client update here is important to remove some security issues in child deps.

davidlehn commented 2 years ago

Leaving Node.js 18 out of the test matrix because the current tests totally fail: https://github.com/digitalbazaar/web-ledger-client/issues/31.