search

digitalbiblesociety / browserbible-3

Bible software that runs in the browser
MIT License
193 stars 77 forks source link

Scrolling problem for the turbo finger #102

Open pdattx opened 7 years ago

pdattx commented 7 years ago

If you try to scroll a little bit faster then the average (especially on a smartphone) you have such big jumps through the bible and a strange effect (that even if you leave the finger than on the touchscreen and swipe around the jumps goes further). You can test it with the biblewebapp.com as well. But the fix seems to be easy: Go to the scroller.js in the windows-folder and comment out the lines ~240 and ~257 : "wrapper.find('.section:first').remove();" and "wrapper.find('.section:last').remove();"

I know that is not the solution, but it helps to have a more direct navigation-control to the application.

Maybe there is another way to remove an exact section without freaking out with the navigation!?

johndyer commented 7 years ago

@pdattx Thanks for this! A few months ago the desktop version of Chrome made some changes, so I changed the the way the system inserted a chapter above the current viewport (lines ~333-363). But I too noticed that now the iPhone browser is getting pretty jumpy again. I know iOS is changing some scrolling behavior to work with Google's AMP and I'm wondering if that's affecting the calculation.

When I tested your idea of removing the code that tries to limit the number of chapters loaded (lines ~203-260), it seemed to help in scrolling downward. But I'm still getting a bit of jumpiness when I scroll upward on an iPhone. Did it solve issues for you in scrolling upward? Are you on iOS or Andriod?

pdattx commented 7 years ago

I'm on iOS, but I must reset my changes in scroller.js. It helps in both directions, yes - that was what I realized - but there were some other effects (it think it was the jump to another chapter or so) that I have to reactivate this lines again. PS: I've taken the last chrome-update as well, but the effect is still there.

pdattx commented 7 years ago

It's also possible to reproduce it on a PC. You must only be fast and if you resize the browser it seems to work faster wrong.

PS: could it be, that in such a case the jump to another chapter is not possible?