digitalcraftsman / hugo-strata-theme

Port of HTML5UP's Strata theme to Hugo
Other
143 stars 92 forks source link

set default if no value is set for variables which require that #49

Closed paskal closed 5 years ago

paskal commented 6 years ago

Fix #48.

hanzei commented 6 years ago

shouldn't this be done for every config settting?

paskal commented 6 years ago

Only this one prevent template from rendering, others are just referenced as empty values. Critical things to fix (which I've reported everywhere and fixed here) are variables which are used by some functions and variables with folder names (without which you won't get your static css and js loaded).

paskal commented 5 years ago

@digitalcraftsman, any chance this PR will be merged?

hanzei commented 5 years ago

Bump