digitalcredentials / dcc-website

https://digitalcredentials.mit.edu
1 stars 7 forks source link

Accessibility issue -- use of headings #18

Closed bmuramatsu closed 1 year ago

bmuramatsu commented 1 year ago

We should only use h1 thru h6 for structural elements. We shouldn't be using it for quotes.

For example on https://digitalcredentials.github.io/dcc-website-jekyll/:

They should have other named styles, and probably named appropriately. Something like dcc-quote, dcc-highlight or something that describes it's use on the page.

fields37 commented 1 year ago

Ah, I understand what you were saying now about separating style from structure, that's a pretty serious problem! I've addressed this in https://github.com/digitalcredentials/dcc-website-jekyll/commit/1a7e8470cc7f687cb9be1e61ceaa6308633f982c so that now each page only has one h1, all subheaders are h2, and quotes + action block text are paragraph elements.