digitalcredentials / dcc-website

https://digitalcredentials.mit.edu
1 stars 7 forks source link

Various Bug Fixes #28

Closed fields37 closed 1 year ago

fields37 commented 1 year ago
fields37 commented 1 year ago

Addressed top three issues here in https://github.com/digitalcredentials/dcc-website-jekyll/pull/6

fields37 commented 1 year ago

The sticky header problem seems to not be affected by z indexes, is pretty inconsistent in how it manifests, and seems to show up only on mobile and not on web. Additionally, on mobile the header sometimes awkwardly remains at the top of the screen once you've scrolled past the footer. Needs additional testing on other devices, but I may end up just removing the sticky header or deactivating it on mobile since it's a fairly small problem to spend a lot of time on.

kayaelle commented 1 year ago

Hey @fields37 - let's remove the sticky header from mobile.

kayaelle commented 1 year ago

@fields37 - I'm not certain what the last checkbox in the list is referencing. Maybe we can find a few mins next week to take a look together.

fields37 commented 1 year ago

Hey @fields37 - let's remove the sticky header from mobile.

Implemented in https://github.com/digitalcredentials/dcc-website-jekyll/commit/cc3c7a553d43b029f8b27b77b90c011b37be32ab

fields37 commented 1 year ago

Call to action issue resolved by changes made in https://github.com/digitalcredentials/dcc-website-jekyll/commit/436e71075d6f4606655a6d8587c66f3ced5daf7a

kayaelle commented 1 year ago

Done