digitalcredentials / dcc-website

https://digitalcredentials.mit.edu
1 stars 7 forks source link

Team Page edits #31

Closed gwalsh311 closed 1 year ago

gwalsh311 commented 1 year ago

@fields37

fields37 commented 1 year ago

Content changes (minus Brandon pending title) completed in https://github.com/digitalcredentials/dcc-website-jekyll/pull/7/commits/6180a0b21a95c8b216ec6db6ef652b29061140ac

Name alignment changed in https://github.com/digitalcredentials/dcc-website-jekyll/pull/7/commits/458602933a6252d4d648d7cfe8cfdd32a17bbd3f. @kayaelle There is still a small margin above the team member name, do you want it completely flush with the top of the image? It currently looks like this: Screen Shot 2023-06-06 at 7 34 30 PM

kayaelle commented 1 year ago

Can we see what it looks like if it is flush to the top of the image so we can compare? Thanks!

fields37 commented 1 year ago

This is what it looks like completely flush, of course we could also aim for somewhere in between, like aligning the top with halfway down the rounded corner of the image!

Screen Shot 2023-06-08 at 12 34 51 PM
gwalsh311 commented 1 year ago

I like the second one personally

kayaelle commented 1 year ago

I like the second one too.

Also take a look at this part in Philipp's bio: "He serves on the board of , a degree-completion college for adult students and was a founding board member of the OpenCourseWare Consortium. He co-authored the ](https://www.collegeunbound.edu/)[Cape Town Open Education Declaration](http://www.capetowndeclaration.org/) and has developed a number of open standards for digital academic credentials including Mozilla Open Badges (PDF)."

Looks like there's a bracket missing after the link for college unbound: ", a degree-completion"

fields37 commented 1 year ago

Bracket issue in Philipp's bio fixed in https://github.com/digitalcredentials/dcc-website-jekyll/pull/10/commits/4edc22ec9972b8e6085abf2ffc457264df0ab6bf

fields37 commented 1 year ago

How does this look to you @kayaelle ? I think it's a bit more balanced than having the top of the text completely aligned with the top of the image, but if you don't like it I'll revert to your recommendation.

Screen Shot 2023-06-12 at 2 23 54 PM
fields37 commented 1 year ago

Also, any updates on Brandon's title?

kayaelle commented 1 year ago

@fields37 - this looks good to me.

re: Brandon's title - it can remain as it is.

@gwalsh311 - if this looks good to you, you can close it.

Thanks!

gwalsh311 commented 1 year ago

Yes looks good to me!

gwalsh311 commented 1 year ago

Closing