Bottom Nav Share, "Create a public link" displays "GT Guide" onscreen after creating the link. - Githubissues

digitalcredentials / learner-credential-wallet

Learner Credential Wallet is a cross-platform iOS and Android mobile application for storing and sharing digital learner credentials.

https://lcw.app

MIT License

54 stars 28 forks source link

Bottom Nav Share, "Create a public link" displays "GT Guide" onscreen after creating the link. #490

Closed bmuramatsu closed 1 year ago

bmuramatsu commented 1 year ago

Occurs in LCW v2.0.11-build 66 on iOS and Android.

(I can't find "GT Guide" text in the JSON of the all the credentials I've tried, nor did a search in the repo turn up anything except for inside mock credentials.) Attached is a credential where one can see the issue.

To reproduce:

Add a credential to LCW
From the bottom nav, select the share icon
Select "Create a public link"
Select (any) credential, and "Create Link" from the "Are you sure?" modal
Note GT Guide at the top of the interstitial screen when the Public Link is getting created and on the resulting Public Link (Beta) screen.

Bottom Nav, Share Screen

Interstitial as Public Link getting created—Note GT Guide

Resulting Public Link screen—Note GT Guide

kayaelle commented 1 year ago

Checking on credential name display

kayaelle commented 1 year ago

"GT Guide" displays no matter what the credential name is. Please change so that the credential name of the chosen credential is displayed.

IsaacAirmet1 commented 1 year ago

https://github.com/digitalcredentials/learner-credential-wallet/pull/501

kayaelle commented 1 year ago

Confirmed that the chosen credential name displays (instead of GT GUIDE) in both ioS and android